Add support for new features in http dispatcher - #374
Merged
Conversation
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/backed-enums
branch
from
August 21, 2026 07:42
2cc6f94 to
1e2895a
Compare
CarlSchwan
changed the title
kesselb
approved these changes
Aug 21, 2026
| $schemas = []; | ||
| $tags = []; | ||
|
|
||
| $enumsByFqcn = []; |
Member
There was a problem hiding this comment.
I'm not so happy with this implementation, because it is limited to the core app.
I had looked into resolving classes at some point and php-parser has a way to do this, that would allow using any enum from any namespace, by resolving it properly.
| try { | ||
| self::resolveIdentifier('', [], $node->getLast()); | ||
| return false; | ||
| } catch (LoggerException) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)